Changeset 4749 for branches/release-0.13.x/pfixcore

Timestamp:

07/27/09 14:56:35 (3 years ago)

Author:

mtld

Message:

SessionEndNotificator? deadlock fix

Location:

branches/release-0.13.x/pfixcore

Files:

• ChangeLog (modified) (1 diff)
• src/de/schlund/pfixcore/workflow/context/SessionContextImpl.java (modified) (1 diff)

branches/release-0.13.x/pfixcore/ChangeLog

@@ +1 @@
+2009-07-27  Martin Leidig  <mleidig@schlund.de>
+
+        Fixed possible deadlock within SessionEndNotificator when
+        one thread adds a SessionListener after getting a lock to an 
+        application object, while another thread is invalidating 
+        the session and calls a registered SessionListener, which itself
+        tries to lock the same application object.
+
 2009-07-09  Martin Leidig  <mleidig@schlund.de>
 

branches/release-0.13.x/pfixcore/src/de/schlund/pfixcore/workflow/context/SessionContextImpl.java

@@ -61 +61 @@
             // Send event to registered listeners
             try {
+                SessionStatusListener[] currentListeners;
                 synchronized (this) {
-                    for (SessionStatusListener l : sessionListeners) {
-                        l.sessionStatusChanged(new SessionStatusEvent(SessionStatusEvent.Type.SESSION_DESTROYED));
-                    }
+                    currentListeners = new SessionStatusListener[sessionListeners.size()];
+                    sessionListeners.toArray(currentListeners);
+                }
+                for (SessionStatusListener l : currentListeners) {
+                    l.sessionStatusChanged(new SessionStatusEvent(SessionStatusEvent.Type.SESSION_DESTROYED));
                 }
             } catch(Throwable t) {